Advice on how to import private sources (makes breaks builtins.fetchGit?) #941
Labels
No labels
dependencies
difficulty::high
difficulty::low
difficulty::medium
good first issue
help wanted
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
justin/makes#941
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hello,
Currently evaluating makes for replacing a bunch of bespoke tooling for unifying developer laptop setups and CI.
So far really happy with usage of
makes, and it's a really good project... but;I'm a bit worried about all the wrangling that's going on underneath the hood. I'm a newcomer to
nix, but ... i'm stumped by the below problem currently.We have some private repositories with expressions that i would like to reuse with
makes. Dependency management is done withnivmuch like you're using it inmakesitself.So i'm currently getting this error;
My module/extension look like:
And, if i evaluate the
builtins.fetchGit {}expression vianix repl, or do a plainnix-buildit works just fine...I hacked around trying to pick apart how nix is getting invoked ... and using that specific nix from the store path, i still don't see the breakage evaluating the basic expression.
Can you help me shed some light on this issue? I would really want to get to a place where i'd recommend
makes, but this seemingly simple problem has caught me a little by surprise.The problem seems to be both present with
makes v22-10andmakes v22-09.Thanks in advance 🙏
Good catch, in general, this is related to: https://github.com/NixOS/nix/issues/3533.
Nix doesn't bundle git nor ssh, or other binaries it needs. However, we currently bundle git with the makes CLI, so builtins.fetchGit is able to find git in the PATH even if the user has not installed it in the host, but, we didn't wrap ssh, but this is easy to fix: https://github.com/fluidattacks/makes/pull/942
@davidreuss Could you please help me test if it works now? Since this is a change in the CLI, you would need to install the latest version of the CLI, like:
nix-env -if https://github.com/fluidattacks/makes/archive/main.tar.gzor something similar. You may need to$ ssh-addyour private ssh key before running makes. I tested it on my machine and it seems to work, but since this is an impurity of Nix I'm not sure if it would work on every machine out there. Thanks for your help testing this!That was fast.
I tried adding
opensshpackage insrc/args/make-derivation/default.nixand following the trail .. but seems like i never found the exact one to actually fix 😅Confirmed that it works just as expected. 🎉
Thank you for the quick fix 🥳