Support nodejs modules from github #860
Labels
No labels
dependencies
difficulty::high
difficulty::low
difficulty::medium
good first issue
help wanted
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
justin/makes#860
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
npm supports installing directly from github repos, which comes in handy as sometimes, maintainers take a long time to publish new versions to npm
https://docs.npmjs.com/cli/v9/configuring-npm/package-json#git-urls-as-dependencies
https://docs.npmjs.com/cli/v9/configuring-npm/package-json#github-urls
perhaps the structure in the package-lock changes a bit, causing makes to fail when installing the deps
Tested with
npm i --save https://github.com/cloudinary-devs/gatsby-source-cloudinary#19a2115fdf876c55ff74756e6dfd8d775bad636cnote: It works well using the tar.gz
npm i --save https://github.com/cloudinary-devs/gatsby-source-cloudinary/archive/19a2115fdf876c55ff74756e6dfd8d775bad636c.tar.gznpm supports both, so it would be worth documenting this behavior in case this becomes a
won't fix@dacevedo12 As we recently migrated to node2nix, it would be nice to tests if this works now.
Seems node2nix is capable of it, but it doesn't find the git binary
@dacevedo12
Maybe by adding
buildInputsviapackageOverridesas shown hereIt only worked at makes level (make-node-js-modules/default.nix), by adding
__nixpkgs__.gitgit via ssh doesn't work but that's a limitation from node2nix https://github.com/svanderburg/node2nix/issues/309
git via https works fine with the aforementioned patch
@dacevedo12 A PR adding git to the builtin is welcome!
Addressed in https://github.com/fluidattacks/makes/pull/1286
Thanks @dsalaza4 node2nix sure was an improvement!