Use full feature set of dockerTools functions #1427
Labels
No labels
dependencies
difficulty::high
difficulty::low
difficulty::medium
good first issue
help wanted
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
justin/makes#1427
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
When trying to build an OCI image with
makes, only the attributesconfiglayers(==contents)layered)maxLayersextraCommandsrunAsRootare definable by the user. Here is the file that defines this:
github.com/fluidattacks/makes@764adcb18b/src/args/make-container-image/default.nix (L3-L20)I have the use-case to use a base image for my OCI image, so I need the
fromImageattribute for both mentioneddockerToolsfunctions, as well as some other attributes (likenameandtag).It would be best, that the user can decide which attributes he needs and can use all attributes of the
dockerTools.buildLayeredImageanddockerTools.buildImagefunctions withmakes.I already made all attributes of the mentioned
dockerToolsfunctions definable by the user. I will open a PR soon.Hey @Justinodactylus,
We're currently working on deprecating most Makes' builtins in favor of having an extremely simplified CLI for core Makes functionality like
makeScriptandmakeTemplate.We haven't deprecated
makeContainerImageyet because we still depend on it, but I would advise you directly usepkgs.dockerToolsfor your tasks, as it is the official way of building containers provided by nixpkgs.Thanks!