Deprecate builtins #1378

Open
opened 2024-09-06 23:45:11 +02:00 by dsalaza4 · 3 comments
dsalaza4 commented 2024-09-06 23:45:11 +02:00 (Migrated from github.com)

Their learning curve is higher than language-specific tools.

Errors require high nix knowledge to debug.

We mainly use them to keep language-specific dependencies as derivations for cache, but for large projects, many times running npm ci is faster than makeNodeJsModules.

I would advise getting rid of all builtins that focus on building language-specific dependencies as derivations and install them on runtime using poetry install or npm ci

Deprecate:

  • makeNodeJs*
  • makePython*
Their learning curve is higher than language-specific tools. Errors require high nix knowledge to debug. We mainly use them to keep language-specific dependencies as derivations for cache, but for large projects, many times running `npm ci` is faster than `makeNodeJsModules`. I would advise getting rid of all builtins that focus on building language-specific dependencies as derivations and install them on runtime using `poetry install` or `npm ci` Deprecate: - [x] `makeNodeJs*` - [ ] `makePython*`
dsalaza4 commented 2024-12-12 01:24:55 +01:00 (Migrated from github.com)

Let's also deprecate:

  • testPython
  • calculateScorecard
  • lintPython
  • formatPython
  • securePythonWithBandit
  • secureKubernetesWithRbacPolice
  • deployNomad
  • taintTerraform
  • lintClojure
  • workspaceForTerraformFromEnv
  • makeSopsEncryptedFile
  • secretsForKubernetesConfigFromAws
  • formatJavascript
  • formatScala
  • lintWithLizard
Let's also deprecate: - [x] testPython - [x] calculateScorecard - [x] lintPython - [x] formatPython - [x] securePythonWithBandit - [x] secureKubernetesWithRbacPolice - [x] deployNomad - [x] taintTerraform - [x] lintClojure - [x] workspaceForTerraformFromEnv - [x] makeSopsEncryptedFile - [x] secretsForKubernetesConfigFromAws - [x] formatJavascript - [x] formatScala - [x] lintWithLizard
dsalaza4 commented 2024-12-13 03:10:22 +01:00 (Migrated from github.com)

Let's also deprecate:

  • testPython
  • calculateScorecard
  • lintPython
  • formatPython
  • securePythonWithBandit
  • secureKubernetesWithRbacPolice
  • deployNomad
  • taintTerraform
  • lintClojure
  • workspaceForTerraformFromEnv
  • makeSopsEncryptedFile
  • secretsForKubernetesConfigFromAws
  • formatJavascript
  • formatScala
  • lintWithLizard

I will release a major makes version deprecating all these builtins (low impact)

> Let's also deprecate: > > * [x] testPython > * [x] calculateScorecard > * [x] lintPython > * [x] formatPython > * [x] securePythonWithBandit > * [x] secureKubernetesWithRbacPolice > * [x] deployNomad > * [x] taintTerraform > * [x] lintClojure > * [x] workspaceForTerraformFromEnv > * [x] makeSopsEncryptedFile > * [x] secretsForKubernetesConfigFromAws > * [x] formatJavascript > * [x] formatScala > * [x] lintWithLizard I will release a major makes version deprecating all these builtins (low impact)
dsalaza4 commented 2024-12-13 04:26:47 +01:00 (Migrated from github.com)

Deprecate:

  • lintGitCommitMsg
  • calculateCvss3
  • chunks
  • escapeShellArg
  • escapeShellArgs
  • filterAttrs
  • flatten
  • fromToml
  • makeDerivationParallel
  • makeNomadEnvironment
  • sortAscii
  • sortAsciiCaseless
  • secretsForGpgFromEnv
  • helloWorld
  • makeSecretForNomadFromEnv
  • makeSecretForKubernetesConfigFromAws
  • makeScriptParallel
Deprecate: - [x] lintGitCommitMsg - [x] calculateCvss3 - [x] chunks - [x] escapeShellArg - [x] escapeShellArgs - [x] filterAttrs - [x] flatten - [x] fromToml - [x] makeDerivationParallel - [x] makeNomadEnvironment - [x] sortAscii - [x] sortAsciiCaseless - [x] secretsForGpgFromEnv - [x] helloWorld - [x] makeSecretForNomadFromEnv - [x] makeSecretForKubernetesConfigFromAws - [x] makeScriptParallel
This discussion has been locked. Commenting is limited to contributors.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
justin/makes#1378
No description provided.