Makes breaks when provenances are too large #1128
Labels
No labels
dependencies
difficulty::high
difficulty::low
difficulty::medium
good first issue
help wanted
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
justin/makes#1128
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
When running jobs that have huge provenance files, the CLI function
_nix_hashesreceives too many arguments and breaks due toARG_MAXlimitations (depending on the OS).Here is where the bug happens
github.com/fluidattacks/makes@2244b2bb1e/src/cli/main/cli.py (L329-L340)Specifically in the
*pathsargument provided to the shell (line 334).Let's make
_nix_hashesreceive bytes from stdin and then callnix-storeusingxargsso it does not hit theARG_MAXlimit.I found this bug by running
m gitlab:fluidattacks/universe@trunk /docs/generate/criteria, as it currently depends on several hundred derivations for building the entire criteria section of the website.