Use Python glob.glob when scanning for main.nix files #1101

Closed
opened 2023-06-02 00:31:47 +02:00 by dsalaza4 · 1 comment
dsalaza4 commented 2023-06-02 00:31:47 +02:00 (Migrated from github.com)

Current scanning function is implemented in Nix. It is very slow:

github.com/fluidattacks/makes@1311f28eb2/src/evaluator/modules/default.nix (L94)

Let's use Python glob.glob and pass all found attrs to Nix.

Current scanning function is implemented in Nix. It is very slow: https://github.com/fluidattacks/makes/blob/1311f28eb2abddbf172da134531d2085ff71d098/src/evaluator/modules/default.nix#L94 Let's use Python `glob.glob` and pass all found attrs to Nix.
dsalaza4 commented 2023-06-05 22:57:49 +02:00 (Migrated from github.com)

I will also release a new version of makes for pinning this CLI change.

I will also release a new version of makes for pinning this CLI change.
This discussion has been locked. Commenting is limited to contributors.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
justin/makes#1101
No description provided.