Add cython and numpy to envDownloads on makePythonPypiEnvironment #1083
Labels
No labels
dependencies
difficulty::high
difficulty::low
difficulty::medium
good first issue
help wanted
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
justin/makes#1083
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Although cython and numpy get bootstrapped to the environment https://github.com/fluidattacks/makes/blob/main/src/args/make-python-pypi-environment/default.nix#L47
It seems like they are not being downloaded from pypi-mirror https://github.com/fluidattacks/makes/blob/main/src/args/make-python-pypi-environment/default.nix#L96
This seems to make them impossible to find when needed.
I will try adding them to
envDownloadsand see if they work properly.@kamadorueda Any idea about why these two specific bootstrapped deps were not taken into account?
I don't recall exactly at this point, but I do remember that bootstrapped and downloaded serve different purposes, and adding it to bootstrapped doesn't mean it's going to be available for download. The reason why some dependencies need to be bootstrapped is that pip expects them to be in the build environment (wheel, setuptools are common ones), if it should be available for download it should be added separately to the sources YAML of the project using Makes, or to this list (if in all projects it should be made available for download):
github.com/fluidattacks/makes@021d05fea3/src/args/make-python-pypi-environment/default.nix (L112)Makes sense! I just opened a PR adding cython to the downloaded sources when the flag is true as I recently found an error where it failed due to not being able to find it even when bootstrapped.