Add cython and numpy to envDownloads on makePythonPypiEnvironment #1083

Closed
opened 2023-05-05 04:50:00 +02:00 by dsalaza4 · 3 comments
dsalaza4 commented 2023-05-05 04:50:00 +02:00 (Migrated from github.com)

Although cython and numpy get bootstrapped to the environment https://github.com/fluidattacks/makes/blob/main/src/args/make-python-pypi-environment/default.nix#L47

It seems like they are not being downloaded from pypi-mirror https://github.com/fluidattacks/makes/blob/main/src/args/make-python-pypi-environment/default.nix#L96

This seems to make them impossible to find when needed.

Although cython and numpy get bootstrapped to the environment https://github.com/fluidattacks/makes/blob/main/src/args/make-python-pypi-environment/default.nix#L47 It seems like they are not being downloaded from pypi-mirror https://github.com/fluidattacks/makes/blob/main/src/args/make-python-pypi-environment/default.nix#L96 This seems to make them impossible to find when needed.
dsalaza4 commented 2023-05-05 04:51:01 +02:00 (Migrated from github.com)

I will try adding them to envDownloads and see if they work properly.

@kamadorueda Any idea about why these two specific bootstrapped deps were not taken into account?

I will try adding them to `envDownloads` and see if they work properly. @kamadorueda Any idea about why these two specific bootstrapped deps were not taken into account?
kamadorueda commented 2023-05-05 21:03:19 +02:00 (Migrated from github.com)

I don't recall exactly at this point, but I do remember that bootstrapped and downloaded serve different purposes, and adding it to bootstrapped doesn't mean it's going to be available for download. The reason why some dependencies need to be bootstrapped is that pip expects them to be in the build environment (wheel, setuptools are common ones), if it should be available for download it should be added separately to the sources YAML of the project using Makes, or to this list (if in all projects it should be made available for download): github.com/fluidattacks/makes@021d05fea3/src/args/make-python-pypi-environment/default.nix (L112)

I don't recall exactly at this point, but I do remember that bootstrapped and downloaded serve different purposes, and adding it to bootstrapped doesn't mean it's going to be available for download. The reason why some dependencies need to be bootstrapped is that pip expects them to be in the build environment (wheel, setuptools are common ones), if it should be available for download it should be added separately to the sources YAML of the project using Makes, or to this list (if in all projects it should be made available for download): https://github.com/fluidattacks/makes/blob/021d05fea30a6b95966ef0b5b2a0b6dfb24e50da/src/args/make-python-pypi-environment/default.nix#L112
dsalaza4 commented 2023-05-05 21:07:05 +02:00 (Migrated from github.com)

Makes sense! I just opened a PR adding cython to the downloaded sources when the flag is true as I recently found an error where it failed due to not being able to find it even when bootstrapped.

Makes sense! I just opened a PR adding cython to the downloaded sources when the flag is true as I recently found an error where it failed due to not being able to find it even when bootstrapped.
This discussion has been locked. Commenting is limited to contributors.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
justin/makes#1083
No description provided.