Validate version mismatch #1076

Open
opened 2023-04-26 16:59:41 +02:00 by dacevedo12 · 2 comments
dacevedo12 commented 2023-04-26 16:59:41 +02:00 (Migrated from github.com)

image

When the user has an old version of makes and attempts to run a command from a newer one

The proposal is to handle this case, showing a clear error on why it happened and how to update makes

![image](https://user-images.githubusercontent.com/29694570/234616753-63c84837-cc7c-45ac-a336-e743bd385a68.png) When the user has an old version of makes and attempts to run a command from a newer one The proposal is to handle this case, showing a clear error on why it happened and how to update makes
dsalaza4 commented 2023-04-26 18:37:52 +02:00 (Migrated from github.com)

I think the best way to do this would be by checking if both the CLI and the framework of Makes are pointing to a commit within the same version.

if not same_version(makes_cli, makes_framework):
   warn(
      f"You are currently using Makes CLI v{makes_cli.version}, "
      f"but have Makes framework v{makes_framework.version} pinned on your makes.lock.nix file. "
      f"This may cause incompatibility issues."
   )
I think the best way to do this would be by checking if both the CLI and the framework of Makes are pointing to a commit within the same version. ``` if not same_version(makes_cli, makes_framework): warn( f"You are currently using Makes CLI v{makes_cli.version}, " f"but have Makes framework v{makes_framework.version} pinned on your makes.lock.nix file. " f"This may cause incompatibility issues." ) ```
dsalaza4 commented 2023-04-26 18:47:03 +02:00 (Migrated from github.com)
We can also forward here: https://makes.fluidattacks.com/versioning/?h=#compatibility-information
This discussion has been locked. Commenting is limited to contributors.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
justin/makes#1076
No description provided.